[incubator-nlpcraft] branch NLPCRAFT-492 updated: NCEntityMapper implementation and related test added.

[sergeykamov]

This is an automated email from the ASF dual-hosted git repository.

sergeykamov pushed a commit to branch NLPCRAFT-492
in repository https://gitbox.apache.org/repos/asf/incubator-nlpcraft.git


The following commit(s) were added to refs/heads/NLPCRAFT-492 by this push:
     new 21d1781  NCEntityMapper implementation and related test added.
21d1781 is described below

commit 21d1781a69299977790fe6e795175bd2a1f6861a
Author: Sergey Kamov <skhdlem...@gmail.com>
AuthorDate: Sun Apr 3 13:47:08 2022 +0300

    NCEntityMapper implementation and related test added.
---
 nlpcraft/src/main/scala/org/apache/nlpcraft/NCPipeline.java          | 5 ++++-
 .../org/apache/nlpcraft/internal/impl/NCModelPipelineManager.scala   | 2 +-
 .../src/test/scala/org/apache/nlpcraft/nlp/util/NCTestPipeline.scala | 1 -
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCPipeline.java 
b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCPipeline.java
index a3ad4fd..b7b84da 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCPipeline.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCPipeline.java
@@ -182,7 +182,10 @@ public interface NCPipeline {
 
     /**
      * TODO:
-     * @return
+     *
+     * Gets optional list of entity mappers.
+     *
+     * @return Optional list of entity mappers. Can be empty but never {@code 
null}.
      */
     default List<NCEntityMapper> getEntityMappers() {
         return Collections.emptyList();
diff --git 
a/nlpcraft/src/main/scala/org/apache/nlpcraft/internal/impl/NCModelPipelineManager.scala
 
b/nlpcraft/src/main/scala/org/apache/nlpcraft/internal/impl/NCModelPipelineManager.scala
index 2529662..c0c5653 100644
--- 
a/nlpcraft/src/main/scala/org/apache/nlpcraft/internal/impl/NCModelPipelineManager.scala
+++ 
b/nlpcraft/src/main/scala/org/apache/nlpcraft/internal/impl/NCModelPipelineManager.scala
@@ -151,7 +151,7 @@ class NCModelPipelineManager(cfg: NCModelConfig, pipeline: 
NCPipeline) extends L
 
         for (m <- entMappers)
             entsList = m.convert(req, entsList, toks)
-            if entsList == null then E("Entity mapper cannot return null 
values/")
+            if entsList == null then E("Entity mapper cannot return null 
values.")
 
         val entities = entsList.asScala.toSeq
 
diff --git 
a/nlpcraft/src/test/scala/org/apache/nlpcraft/nlp/util/NCTestPipeline.scala 
b/nlpcraft/src/test/scala/org/apache/nlpcraft/nlp/util/NCTestPipeline.scala
index 9698d9b..533590d 100644
--- a/nlpcraft/src/test/scala/org/apache/nlpcraft/nlp/util/NCTestPipeline.scala
+++ b/nlpcraft/src/test/scala/org/apache/nlpcraft/nlp/util/NCTestPipeline.scala
@@ -21,7 +21,6 @@ import org.apache.nlpcraft.*
 import org.apache.nlpcraft.nlp.token.parser.NCOpenNLPTokenParser
 import org.apache.nlpcraft.nlp.util.NCTestPipeline.*
 
-import java.util
 import java.util.{Optional, ArrayList as JList}
 
 /**