This is an automated email from the ASF dual-hosted git repository.

aradzinski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nlpcraft.git

commit 24833e3ef379f710d79739a9ef373da71608533c
Merge: 5e325a0b ae1d2ee0
Author: Aaron Radzinski <[email protected]>
AuthorDate: Fri Apr 8 19:45:08 2022 -0700

    Merge branch 'master' of https://github.com/apache/incubator-nlpcraft

 nlpcraft-examples/echo/README.md                   |    50 -
 nlpcraft-examples/echo/pom.xml                     |    62 -
 .../apache/nlpcraft/examples/time/EchoModel.java   |    65 -
 .../echo/src/main/resources/cities_timezones.txt   | 23157 -------------------
 .../echo/src/main/resources/time_model.yaml        |    27 -
 .../examples/time/NCModelValidationSpec.scala      |    41 -
 .../main/scala/org/apache/nlpcraft/NCPipeline.java |   130 +-
 .../org/apache/nlpcraft/NCPipelineBuilder.java     |     3 +
 .../internal/dialogflow/NCDialogFlowManager.scala  |     6 +-
 .../internal/conversation/NCConversationSpec.scala |    25 +
 .../nlpcraft/nlp/NCEntityValidatorSpec.scala       |     8 +-
 .../apache/nlpcraft/nlp/NCTokenValidatorSpec.scala |     7 +-
 pom.xml                                            |     1 -
 13 files changed, 72 insertions(+), 23510 deletions(-)

diff --cc nlpcraft/src/main/scala/org/apache/nlpcraft/NCPipeline.java
index 81e7c26a,8415a873..79bce7fa
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCPipeline.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCPipeline.java
@@@ -135,18 -64,14 +64,15 @@@ public interface NCPipeline 
      NCTokenParser getTokenParser();
  
      /**
 +     * Gets the list of entity parser. At least one entity parser is required.
       *
-      * @return List of entity parser. List should contain at least one entity 
parser.
+      * @return
       */
-     default List<NCEntityParser> getEntityParsers() {
-         return Collections.emptyList();
-     }
+     List<NCEntityParser> getEntityParsers();
  
      /**
-      * Gets optional list of token enrichers.
       *
-      * @return Optional list of token enrichers. Can be empty but never 
{@code null}.
+      * @return
       */
      default List<NCTokenEnricher> getTokenEnrichers() {
          return Collections.emptyList();
@@@ -187,8 -108,11 +109,8 @@@
      default Optional<NCVariantFilter> getVariantFilter() {
          return Optional.empty();
      }
 -
--
++    
      /**
 -     * TODO:
 -     *
       * Gets optional list of entity mappers.
       *
       * @return Optional list of entity mappers. Can be empty but never {@code 
null}.

Reply via email to