jkivilin commented on issue #24: Fix wait loop and void cast
URL: https://github.com/apache/incubator-nuttx/pull/24#issuecomment-572116950
 
 
   Bug appears to be reproducable with 'usrsocktest' testing application 
(CONFIG_EXAMPLES_USRSOCKTEST=y). 
   
   The config I used for quick test is at 
https://gist.github.com/jkivilin/7d7558b54a85fd70c8a439d6d8feba5e
   
   With offending commit **reverted**, I get output:
   ```
   $ ./nuttx 
   
   NuttShell (NSH) NuttX-8.2
   MOTD: username=admin password=Administrator
   nsh> usrsocktest
   Starting unit-tests...
   Testing group "CharDev" =>
           Group "CharDev": [OK]
   Testing group "NoDaemon" =>
           Group "NoDaemon": [OK]
   Testing group "BasicDaemon" =>
           Group "BasicDaemon": [OK]
   Testing group "BasicConnect" =>
           Group "BasicConnect": [OK]
   Testing group "BasicConnectDelay" =>
           Group "BasicConnectDelay": [OK]
   Testing group "NoBlockConnect" =>
           Group "NoBlockConnect": [OK]
   Testing group "BasicSend" =>
           Group "BasicSend": [OK]
   Testing group "NoBlockSend" =>
           Group "NoBlockSend": [OK]
   Testing group "BlockSend" =>
           Group "BlockSend": [OK]
   Testing group "NoBlockRecv" =>
           [TEST ASSERT FAILED!]
                   In function "Receive":
                   line 200: Assertion `memcmp((&remoteaddr), (&addr), 
(addrlen)) == 0' failed.
           Group "NoBlockRecv": [FAILED]
   Testing group "BlockRecv" =>
           [TEST ASSERT FAILED!]
                   In function "NoBlockConnect":
                   line 268: Assertion `memcmp((&remoteaddr), (&addr), 
(addrlen)) == 0' failed.
           Group "BlockRecv": [FAILED]
   Testing group "RemoteDisconnect" =>
           Group "RemoteDisconnect": [OK]
   Testing group "BasicSetSockOpt" =>
           Group "BasicSetSockOpt": [OK]
   Testing group "BasicGetSockOpt" =>
           Group "BasicGetSockOpt": [OK]
   Testing group "BasicGetSockName" =>
   Segmentation fault (core dumped)
   ```
   
   There is some other issue that causes test-cases to fail, but when 6a3c2ad 
is **not reverted**, the output changes.  Now I get different errors, first 
being at 'Testing group "BasicSend"':
   
   ```
   $ ./nuttx 
   
   NuttShell (NSH) NuttX-8.2
   MOTD: username=admin password=Administrator
   nsh> 
   nsh> usrsocktest
   Starting unit-tests...
   Testing group "CharDev" =>
           Group "CharDev": [OK]
   Testing group "NoDaemon" =>
           Group "NoDaemon": [OK]
   Testing group "BasicDaemon" =>
           Group "BasicDaemon": [OK]
   Testing group "BasicConnect" =>
           Group "BasicConnect": [OK]
   Testing group "BasicConnectDelay" =>
           Group "BasicConnectDelay": [OK]
   Testing group "NoBlockConnect" =>
           Group "NoBlockConnect": [OK]
   Testing group "BasicSend" =>
           [TEST ASSERT FAILED!]
                   In function "ConnectSend":
                   line 244: Assertion `(ssize_t)((ret)) == 
(ssize_t)((datalen))' failed.
                           got value: -1
                           should be: 4
           Group "BasicSend": [FAILED]
   Testing group "NoBlockSend" =>
           [TEST ASSERT FAILED!]
                   In function "Send":
                   line 111: Assertion 
`(ssize_t)((usrsocktest_daemon_start(dconf))) == (ssize_t)((0))' failed.
                           got value: -120
                           should be: 0
           Group "NoBlockSend": [FAILED]
   Testing group "BlockSend" =>
           [TEST ASSERT FAILED!]
                   In function "ConnectSend":
                   line 112: Assertion 
`(ssize_t)((usrsocktest_daemon_start(dconf))) == (ssize_t)((0))' failed.
                           got value: -120
                           should be: 0
           Group "BlockSend": [FAILED]
   Testing group "NoBlockRecv" =>
           [TEST ASSERT FAILED!]
                   In function "Receive":
                   line 115: Assertion 
`(ssize_t)((usrsocktest_daemon_start(dconf))) == (ssize_t)((0))' failed.
                           got value: -120
                           should be: 0
           Group "NoBlockRecv": [FAILED]
   Testing group "BlockRecv" =>
           [TEST ASSERT FAILED!]
                   In function "ConnectReceive":
                   line 114: Assertion 
`(ssize_t)((usrsocktest_daemon_start(dconf))) == (ssize_t)((0))' failed.
                           got value: -120
                           should be: 0
           Group "BlockRecv": [FAILED]
   Testing group "RemoteDisconnect" =>
           [TEST ASSERT FAILED!]
                   In function "Unreachable":
                   line 115: Assertion 
`(ssize_t)((usrsocktest_daemon_start(dconf))) == (ssize_t)((0))' failed.
                           got value: -120
                           should be: 0
           Group "RemoteDisconnect": [FAILED]
   Testing group "BasicSetSockOpt" =>
           [TEST ASSERT FAILED!]
                   In function "Open":
                   line 105: Assertion 
`(ssize_t)((usrsocktest_daemon_start(dconf))) == (ssize_t)((0))' failed.
                           got value: -120
                           should be: 0
           Group "BasicSetSockOpt": [FAILED]
   Testing group "BasicGetSockOpt" =>
           [TEST ASSERT FAILED!]
                   In function "Open":
                   line 105: Assertion 
`(ssize_t)((usrsocktest_daemon_start(dconf))) == (ssize_t)((0))' failed.
                           got value: -120
                           should be: 0
           Group "BasicGetSockOpt": [FAILED]
   Testing group "BasicGetSockName" =>
           [TEST ASSERT FAILED!]
                   In function "Open":
                   line 110: Assertion 
`(ssize_t)((usrsocktest_daemon_start(dconf))) == (ssize_t)((0))' failed.
                           got value: -120
                           should be: 0
           Group "BasicGetSockName": [FAILED]
   Testing group "WakeWithSignal" =>
           [TEST ASSERT FAILED!]
                   In function "do_wake_test":
                   line 487: Assertion 
`(ssize_t)((usrsocktest_daemon_start(&usrsocktest_daemon_config))) == 
(ssize_t)((0))' failed.
                           got value: -120
                           should be: 0
           Group "WakeWithSignal": [FAILED]
   Testing group "MultiThread" =>
           [TEST ASSERT FAILED!]
                   In function "usrsocktest_test_MultiThread_OpenClose":
                   line 221: Assertion 
`(ssize_t)((usrsocktest_daemon_start(&usrsocktest_daemon_config))) == 
(ssize_t)((0))' failed.
                           got value: -120
                           should be: 0
           Group "MultiThread": [FAILED]
   Unit-test groups done... OK:6, FAILED:11, TOTAL:17
    -- number of checks made: 786
   HEAP BEFORE TESTS:
                total       used       free    largest
   Mem:       4194304    1597616    2596688    2596432
   HEAP AFTER TESTS:
                total       used       free    largest
   Mem:       4194304    1607440    2586864    2586800
   nsh>
   ```
   
   Maybe above can be used to locate the issue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to