patacongo commented on a change in pull request #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#discussion_r379005150
########## File path: drivers/i2c/Kconfig ########## @@ -54,3 +50,7 @@ config I2CMULTIPLEXER_PCA9540BDP endmenu # I2C Multiplexer Support endif + +config ARCH_HAVE_I2CRESET Review comment: i suppose it could even go at the end of drivers/i2c/Kconfig That is not very comfortable. But I am not comfortable with the breaking of the naming convention either. The first word of the configuration name is suppose to be a clue where you can find the configuration definition. So everything in drivers/Kconfig should be named DRIVERS_, everything under drivers/i2c/Kconfig should be named I2C. This belong in arch/Kconfig. Evertything in arch/Kconfig should be named ARCH_ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
