patacongo commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-589960471 So what kinds of things can we do now to prevent a dependency of all architectures on drivers/timer/arch_timer.c? There is a precedent for something like CONFIG_ARCH_CUSTOM_MDELAY. Like this patch, every implementation of up_mdelay() would depend on "#ifdef CONFIG_ARCH_CUSTOM_MDELAY" and this would be defined in arch/Kconfig like: config ARCH_CUSTOM_MDELAY bool default n Then in drivers/timers/Kconfig, you could do config TIMER_ARCH bool "Timer Arch Implementation" select ARCH_HAVE_TICKLESS select ARCH_HAVE_TIMEKEEPING select ARCH_CUSTOM_MDELAY ---help--- Implement timer arch API on top of timer driver interface. This is logically the same. It is not elegant and it is not the quality of modularity that I would like to have. But at least it would prevent all architectures from being completely dependent on a particular external driver (which is not acceptable).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
