adamfeuer commented on issue #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends URL: https://github.com/apache/incubator-nuttx/pull/372#issuecomment-591032917 @Ouss4 @patacongo @xiaoxiang781216 Thanks for the improvements and help– I ran `tools/checkpatch.sh` against the two files in this PR, and made a bunch of cleanups... many of the `nxstyle`-suggested changes were code I didn't touch, but I cleaned them up anyway. In the `sam_gmac.h` file, there were a bunch of `nxstyle` errors from the previous code that I didn't fix... they were multiple instances of: * error: Missing blank line after comment * error: Mixed case identifier found I didn't fix these because it seemed the suggestions would be out of character for the formatting in the file. But I'm willing to make the changes to get the file to the point that there are no `nxstyle` errors. What should I do? Will you take a look at these changes and see what you think? Do you have further improvements?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
