patacongo opened a new issue #439: Video: Correct use of global variable URL: https://github.com/apache/incubator-nuttx/issues/439 Reported to me via email: The v4l2-like layer (video.c) uses a global variable inappropriately. A global variable is used instead of creating a struct in /boards/ and passing it. So we have g_video_devops->set_buf(...) for example g_video_devops being declared in video.h: FAR const struct video_devops_s *g_video_devops; And being used in the CXD56xx board here: boards/arm/cxd56xx/spresense/src/cxd56_bringup.c: g_video_devops = isx012_initialize(); Wouldn't it be better to create the pointer in boards and pass it as argument ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
