patacongo commented on a change in pull request #444: SAMA5D27 peripheral 
support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597128
 
 

 ##########
 File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig
 ##########
 @@ -8,7 +8,7 @@
 # CONFIG_AUDIO_FORMAT_MP3 is not set
 
 Review comment:
   Please do not modify the generic nsh configuration.  People expect nsh 
configurations to be simple.  Please create a new configuration, perhaps called 
netnsh (as for other configurations).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to