xiaoxiang781216 commented on a change in pull request #599: sim: Add a CLI 
option to override vpnkit socket
URL: https://github.com/apache/incubator-nuttx/pull/599#discussion_r395994709
 
 

 ##########
 File path: arch/sim/src/sim/up_head.c
 ##########
 @@ -77,6 +78,8 @@ static char g_logbuffer[4096];
 
 int main(int argc, char **argv, char **envp)
 {
+  process_cli_options(argc, argv);
 
 Review comment:
   > @xiaoxiang781216
   > how would it skip an unknown option, say, -g?
   > note that -g might or might not take an argument.
   
   Yes, getopt can't handle the option with argument. But I still think the 
code struct is better even we have to parse the argument directly, do you think 
so?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to