xiaoxiang781216 commented on a change in pull request #185: nsh improvement URL: https://github.com/apache/incubator-nuttx-apps/pull/185#discussion_r410913625
########## File path: nshlib/nsh_altconsole.c ########## @@ -292,12 +294,6 @@ int nsh_consolemain(int argc, char *argv[]) netinit_bringup(); #endif -#if defined(CONFIG_NSH_ARCHINIT) && defined(CONFIG_BOARDCTL_FINALINIT) - /* Perform architecture-specific final-initialization (if configured) */ - - boardctl(BOARDIOC_FINALINIT, 0); -#endif - Review comment: BOARDIOC_FINALINIT spread in many place, it's better to put into one place: nsh_initscript. Since this PR contain all issues I found in reviewing nsh iniitialization process, it's better to review each patch one by one at here: https://github.com/apache/incubator-nuttx-apps/pull/185/commits Each commit message describe why I make this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
