ppisa commented on code in PR #12081:
URL: https://github.com/apache/nuttx/pull/12081#discussion_r1564997813


##########
arch/arm/src/samv7/Kconfig:
##########
@@ -3786,6 +3786,19 @@ config SAMV7_TC3_QE
        ---help---
                Reserve TC3 for use by QEncoder.
 
+config SAMV7_QENCODER_ENABLE_GETINDEX
+       bool "Support ioctl GETINDEX call"
+       default n

Review Comment:
   In the fact there can be two independent options configurable for each 
encoder, the first index resets the counter, the second the position and index 
should be extended to 32-bits. But when you consider adding these 8 options and 
all ifdefs etc. then we have decided to leave single option and simpler code 
for now. When somebody know what is he/she doing when enables GETINDEX on SAMv7 
then all previous behavior can be achieved back by subtraction index from 
position, limiting size etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to