Re: [PR] arch/risc-v: Make bl602 allocate idle stack after ebss [nuttx]

[via GitHub]

xiaoxiang781216 commented on code in PR #12288:
URL: https://github.com/apache/nuttx/pull/12288#discussion_r1590561284


##########
boards/risc-v/bl602/bl602evb/scripts/ld.script:
##########
@@ -185,18 +179,11 @@ SECTIONS
     *(COMMON)
   } > ram_tcm
 
-  . = ALIGN(4);
-
-  PROVIDE( _heap_start = . );
-  PROVIDE( _heap_size = ADDR(.stack) - _heap_start );
-
-  /* .stack ORIGIN(ram_tcm) + LENGTH(ram_tcm) - __stack_size (NOLOAD) : */
-  .stack ORIGIN(ram_tcm) + LENGTH(ram_tcm) (NOLOAD) :
+  .stack_top (NOLOAD) :
   {
-    PROVIDE( _sp_irq_base = . );
-    /* . = . + __stack_size; */
-    /* PROVIDE( _sp_main = . ); */
-  } >ram_tcm
+    . = ALIGN(16);
+    _ebss = ABSOLUTE(.);

Review Comment:
   mov  after line 179



##########
boards/risc-v/bl602/bl602evb/scripts/ld.script:
##########
@@ -185,18 +179,11 @@ SECTIONS
     *(COMMON)
   } > ram_tcm
 
-  . = ALIGN(4);
-
-  PROVIDE( _heap_start = . );
-  PROVIDE( _heap_size = ADDR(.stack) - _heap_start );
-
-  /* .stack ORIGIN(ram_tcm) + LENGTH(ram_tcm) - __stack_size (NOLOAD) : */
-  .stack ORIGIN(ram_tcm) + LENGTH(ram_tcm) (NOLOAD) :
+  .stack_top (NOLOAD) :

Review Comment:
   remove the empty .stack_top



##########
boards/risc-v/bl602/bl602evb/scripts/ld.script:
##########
@@ -16,6 +16,10 @@ MEMORY
   ram_wifi  (wxa)    : ORIGIN = 0x42030000, LENGTH = (112K - 8K) /* 8K left 
for em */
 }
 
+__ram_tcm_start = ORIGIN(ram_tcm);
+__ram_tcm_size = LENGTH(ram_tcm);
+__ram_tcm_end = ORIGIN(ram_tcm) + LENGTH(ram_tcm);

Review Comment:
   remove all



##########
boards/risc-v/bl602/bl602evb/scripts/ld.script:
##########
@@ -185,18 +179,11 @@ SECTIONS
     *(COMMON)
   } > ram_tcm
 
-  . = ALIGN(4);
-
-  PROVIDE( _heap_start = . );
-  PROVIDE( _heap_size = ADDR(.stack) - _heap_start );

Review Comment:
   let's add:
   ```
   PROVIDE(__heap_end = ORIGIN(ram_tcm) + LENGTH(ram_tcm));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org