trns1997 commented on code in PR #10534: URL: https://github.com/apache/nuttx/pull/10534#discussion_r1610510104
########## boards/arm/a1x/pcduino-a10/configs/nsh/defconfig: ########## @@ -46,3 +46,4 @@ CONFIG_START_YEAR=2013 CONFIG_SYMTAB_ORDEREDBYNAME=y CONFIG_SYSTEM_NSH=y CONFIG_UART0_SERIAL_CONSOLE=y +CONFIG_ARCH_BOARD_COMMON=y Review Comment: hey @xiaoxiang781216, i was thinking of addressing this PR finally. I wanted your input regarding this discussing. Do you thins adding `CONFIG_ARCH_BOARD_COMMON=y` to boards that support common folder is acceptable? For now i was thinking of adding it to the STM32 boards and XMC4, or is it generally not a good idea and we want the user to be responsible for setting this option? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
