yf13 commented on code in PR #12475: URL: https://github.com/apache/nuttx/pull/12475#discussion_r1637421732
########## arch/risc-v/include/inttypes.h: ########## @@ -29,7 +29,18 @@ * Pre-processor Definitions ****************************************************************************/ -#if defined(CONFIG_ARCH_RV64) +#if defined(CONFIG_ARCH_RV64ILP32) Review Comment: I am unsure, actually the 32 bit definitions looks a little strange to me as `int` is 32-bit thus no modifiers is needed. ########## arch/risc-v/include/types.h: ########## @@ -54,12 +54,21 @@ typedef unsigned char _uint8_t; typedef signed short _int16_t; typedef unsigned short _uint16_t; +/* We could use `long long` as 64-bit for all ABIs, but that causes + * "format warings" beyond arch/risc-v scope. So let's revisit it later. + */ + #ifdef CONFIG_ARCH_RV64 typedef signed int _int32_t; typedef unsigned int _uint32_t; +#ifndef CONFIG_ARCH_RV64ILP32 Review Comment: let me try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
