xiaoxiang781216 commented on code in PR #12652:
URL: https://github.com/apache/nuttx/pull/12652#discussion_r1671492053
##########
drivers/note/note_initialize.c:
##########
@@ -52,11 +52,11 @@
int note_early_initialize(void)
{
- int ret = 0;
+ int ret = OK;
Review Comment:
> note_driver_register() will return OK, why not replace 0 to OK?
https://github.com/apache/nuttx/blob/master/drivers/note/note_driver.c#L1983
If so, It's better to change OK to 0.
> @xiaoxiang781216 The usage of OK is what **you** have been insisting on
before, you could check your previous review comments.
Where do I prefer OK/ERROR? If I suggest to use OK/ERROR before, I guess
just because the original code already use OK/ERROR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
