dry-75 commented on code in PR #2456: URL: https://github.com/apache/nuttx-apps/pull/2456#discussion_r1696265228
########## nshlib/nsh_ddcmd.c: ########## @@ -385,7 +385,7 @@ int cmd_dd(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv) if (dd.skip) { ret = lseek(dd.infd, dd.skip * dd.sectsize, SEEK_SET); - if (ret < -1) + if (ret < 0) Review Comment: That would be, pedantic, but perhaps then leave it for next common fix PR : updating both dds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org