jinxiuxu commented on code in PR #13005:
URL: https://github.com/apache/nuttx/pull/13005#discussion_r1724153237


##########
arch/sim/src/sim/posix/sim_alsa.c:
##########
@@ -462,9 +462,16 @@ static int sim_audio_configure(struct audio_lowerhalf_s 
*dev,
         priv->sample_rate = caps->ac_controls.hw[0] |
                             (caps->ac_controls.b[3] << 16);
         priv->channels    = caps->ac_channels;
-        priv->bps         = caps->ac_controls.b[2];
-        priv->frame_size  = priv->bps / 8 * priv->channels;
 
+        /* offload mode, bps keep default value */
+
+        priv->bps = 16;

Review Comment:
   > why not 8, @jinxiuxu
   default value is set to 16 in sim_audio_initialize, and we want to keep it 
here.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to