xiaoxiang781216 commented on code in PR #13239:
URL: https://github.com/apache/nuttx/pull/13239#discussion_r1738669219
##########
arch/arm/src/armv8-r/arm_gicv3.c:
##########
@@ -101,7 +101,7 @@ static inline int sys_test_bit(unsigned long addr, unsigned
int bit)
static inline unsigned long gic_get_rdist(void)
{
- return gic_rdists[this_cpu()];
+ return g_gic_rdists[up_cpu_index()];
Review Comment:
but the access will touch the end of g_gic_rdists in non SMP case.
##########
arch/arm64/src/common/arm64_gicv3.c:
##########
@@ -112,7 +112,7 @@ static inline int sys_test_bit(unsigned long addr, unsigned
int bit)
static inline unsigned long gic_get_rdist(void)
{
- return gic_rdists[this_cpu()];
+ return g_gic_rdists[up_cpu_index()];
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
