anchao commented on code in PR #13285: URL: https://github.com/apache/nuttx/pull/13285#discussion_r1742057404
########## include/nuttx/can/can.h: ########## @@ -946,46 +931,6 @@ int can_txdone(FAR struct can_dev_s *dev); int can_txready(FAR struct can_dev_s *dev); #endif -/**************************************************************************** - * Name: can_bytes2dlc - * - * Description: - * In the CAN FD format, the coding of the DLC differs from the standard - * CAN format. The DLC codes 0 to 8 have the same coding as in standard - * CAN. But the codes 9 to 15 all imply a data field of 8 bytes with - * standard CAN. In CAN FD mode, the values 9 to 15 are encoded to values - * in the range 12 to 64. - * - * Input Parameters: - * nbytes - the byte count to convert to a DLC value - * - * Returned Value: - * The encoded DLC value corresponding to at least that number of bytes. - * - ****************************************************************************/ - -uint8_t can_bytes2dlc(uint8_t nbytes); Review Comment: why change the public function to private? You should describe the feature of this PR or what issue which solves in the commit message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
