patacongo commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r443061207
##########
File path: sched/Kconfig
##########
@@ -975,7 +975,7 @@ config SCHED_INSTRUMENTATION_SPINLOCKS
config SCHED_INSTRUMENTATION_SYSCALL
bool "System call monitor hooks"
default n
- depends on LIB_SYSCALL && ARCH_HAVE_SYSCALL_HOOKS
+ depends on ARCH_HAVE_SYSCALL_HOOKS
Review comment:
This absolutely must be reverted!!!!!!!!!!!!!!!!!!!!!!
In the FLAT build, CONFIG_LIB_SYSCALL may or may not be defined. If this
CONFIG_LIB_SYSCALL is NOT defined, then this selection will be present in the
menus. THAT IS ABSOLUTELY WRONG. There should be no invalid menu selection
visible. This is necessary to keep the complexity of the configuration menus
down.
And the logic is wrong AND IS A BUG. If someone does select
CONFIG_SCHED_INSTRUMENTATION_SYSCALL when CONFIG_LIB_SYSCALL is *not* defined
then the dead code will bet built into the system. THAT CANNOT BE PERMITTED.
We must not permit invalid configuration options.
THIS MUST BE REVERTED!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
