patacongo commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r443135232
##########
File path: sched/Kconfig
##########
@@ -975,7 +975,7 @@ config SCHED_INSTRUMENTATION_SPINLOCKS
config SCHED_INSTRUMENTATION_SYSCALL
bool "System call monitor hooks"
default n
- depends on LIB_SYSCALL && ARCH_HAVE_SYSCALL_HOOKS
+ depends on ARCH_HAVE_SYSCALL_HOOKS
Review comment:
> @YuuichiNakamura already support the filter and document here:
>
https://github.com/YuuichiNakamura/nuttx-task-tracer-doc/blob/master/NuttXTaskTracer.md
> This filter is done at the runtime(I guess inside the
sched_trace.c/sched_note.c driver). So we can:
> 1.Turn on/off the whole syscall instrumentation by
SCHED_INSTRUMENTATION_SYSCALL
> 2.Turn on/off the individual syscall from command line at runtime
> The 3rd approach(static filter) only instrument a specific set of
syscall(e.g. provide the cut down syscall.csv). But I wonder whether the static
filter is required if we already have more powerful runtime filter.
Of course, that #2) CANNOT work for the hardware based solution since there
is no user accessible driver in the hardware solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
