nuttxpr commented on PR #2663: URL: https://github.com/apache/nuttx-apps/pull/2663#issuecomment-2402162650
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** Here's why and how to improve it: * **Insufficient Summary:** * **Missing "Why":** You haven't explained the reason for this change. Is it a bug fix? A new feature request? * **Missing Details:** "Screen offset" is vague. What part of the codebase handles this? How is the offset configured? Be specific. * **Incomplete Impact:** * **"None" is Unlikely:** Almost every change has *some* impact. Consider these: * **User Impact:** How do users set this offset? Is there a new configuration option? * **Documentation Impact:** This new feature needs to be documented. * **Hardware Impact:** Does this only apply to specific display drivers? * **Insufficient Testing:** * **"Daily test" is not specific:** Which tests were run? Provide test names or descriptions relevant to this change. * **No Logs:** The template asks for logs before and after the change, but you haven't included any. **How to Improve this PR:** 1. **Expand the Summary:** Clearly state the problem this PR solves or the feature it adds. Provide specific details about the code being modified. 2. **Thoroughly Analyze Impact:** Go through each impact category and be realistic. If something is truly "NO", briefly explain why. 3. **Provide Detailed Testing Information:** * List the specific tests performed. * Include relevant snippets from your testing logs that demonstrate the change's effect. **Remember:** A good PR is about communication. Help reviewers understand your changes quickly and thoroughly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
