nuttxpr commented on PR #14015: URL: https://github.com/apache/nuttx/pull/14015#issuecomment-2403767278
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements as they are currently described.** Here's why and how to fix it: * **Insufficient Detail:** The provided information is far too brief. You need to expand on each section substantially. **Here's a breakdown of what needs improvement:** **Summary:** * **Why is this change necessary?** Is there a specific use case demanding nanosecond precision? Are existing delay mechanisms insufficient? * **What code is being changed?** Be specific. Mention the files and functions you've modified. * **How does it work?** Explain the mechanism used to achieve nanosecond delays with the TSC. Don't assume the reviewer understands your approach. * **Link any related issues:** Are you addressing a reported bug or feature request? Provide links to relevant NuttX issues. **Impact:** * **You claim "no impact," but that's unlikely.** Adding a new interface always has some impact. Consider: * **Increased code size:** Even a small addition affects memory footprint, especially on resource-constrained devices. * **Potential timing changes:** Could this modification affect the timing of other parts of the system, even subtly? * **Hardware dependencies:** Does the TSC approach work on all supported architectures? **Testing:** * **"ostest" is not descriptive enough.** Specify: * Which OS you used for your host build environment. * The target architecture and board configuration. * **Provide relevant snippets of log output before and after your changes.** Highlight the differences and how they demonstrate the functionality of your nanosecond delay. **To summarize:** You need to provide significantly more context and detail in your PR for it to be considered complete. Clear and comprehensive documentation is essential for maintainers to understand, review, and merge your changes effectively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
