nuttxpr commented on PR #14021: URL: https://github.com/apache/nuttx/pull/14021#issuecomment-2403871686
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * **What functional part of the code is being changed?** Be specific. Which files, modules, or subsystems are affected? * **How does the change exactly work?** Provide more detail on the technical implementation of the change from `asm()` to `__asm__()`. * **Impact:** * While you state "no impact," you need to explicitly answer each question with "NO" or provide details if "YES." For example: * Is new feature added? **NO** * Is existing feature changed? **NO** * ... (answer all impact questions) * **Testing:** * **Build Host(s):** Specify your build host operating system, CPU architecture, and compiler details. * **Target(s):** List the specific architectures and boards you tested on. * **Testing logs:** "ostest" is not sufficient. Provide actual log snippets or test output demonstrating the problem before the change and the correct behavior after the change. **Example of Improved Testing Section:** ``` ## Testing I confirm that changes are verified on the local setup and work as intended: * Build Host(s): Linux (Ubuntu 20.04), x86_64, GCC 9.4.0 * Target(s): * sim:qemu-arm * arm:stm32f4discovery Testing logs before change: ``` (Insert relevant log output showing the issue with `asm()` and `-std=c99` ) ``` Testing logs after change: ``` (Insert relevant log output showing the code compiles and functions correctly with `__asm__()`) ``` **To proceed with this PR, please provide the missing information and detailed testing results.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
