nuttxpr commented on PR #14037: URL: https://github.com/apache/nuttx/pull/14037#issuecomment-2404562442
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** meet the NuttX requirements. **Here's why and how to improve it:** * **Summary is incomplete:** * **Missing "Why":** Why is getline backspace support necessary? Is there a bug report or feature request driving this? * **Missing "How":** Provide a technical explanation of how you implemented backspace support within getline. * **Link Issues/PRs:** If this relates to existing issues in NuttX or NuttX Apps, provide the links. * **Impact is too brief:** * Even if there's no user-facing impact, you should confirm this explicitly for each category: * "No new features added." * "No changes to existing features." * "No changes to the build process." * ...and so on for all categories. * **Consider unintended consequences:** Could this change, even a seemingly small one, have unexpected side effects? * **Testing is insufficient:** * **Provide details:** * Which simulator? (e.g., qemu-system-arm, qemu-system-riscv64) * Specific ARM64 board and configuration used. * **Show, don't tell:** Include snippets of your testing logs demonstrating the problem before the change and the improvement after. * **Test breadth:** Did you test different input scenarios (long lines, special characters)? Did you test on real hardware if possible? **Example of an Improved Summary:** This PR addresses [Issue #] by adding backspace support to the `getline` function. Previously, backspace characters were treated as regular input, making line editing impossible. The implementation modifies the internal buffer handling of `getline` to correctly handle backspace characters, deleting the previous character and adjusting the cursor position. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
