nuttxpr commented on PR #14112: URL: https://github.com/apache/nuttx/pull/14112#issuecomment-2406984623
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## PR Review against NuttX Requirements: **Meets Requirements?** Partially **Summary:** * The summary provides the "why" (needed for tlpi example), but lacks details on "what" and "how" the change is implemented. **Impact:** * The impact section is completely missing. This is critical for reviewers to understand the breadth of the changes. **Testing:** * The PR description *must* include testing details: * What build hosts were used to validate? (OS, Compiler, etc.) * What target hardware or simulators were tested? * Provide *both* "before" and "after" logs demonstrating the fix. **Recommendations:** 1. **Expand Summary:** Clearly state WHAT `CPU_SETSIZE` is, HOW its definition helps the tlpi example, and WHERE in `sched.h` it's added. 2. **Complete Impact Section:** Address ALL points, even if the answer is "NO" with a brief justification. Pay close attention to: * **Compatibility:** Does this macro definition affect other code? * **Documentation:** Does `sched.h` need any comments for this? 3. **Provide Thorough Testing Details:** Follow the template's structure for logs. **Concisely:** The PR needs significant work to meet NuttX standards, particularly in impact assessment and testing evidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
