anchao commented on code in PR #14083:
URL: https://github.com/apache/nuttx/pull/14083#discussion_r1797605849
##########
sched/sched/sched_suspendscheduler.c:
##########
@@ -63,7 +63,7 @@ void nxsched_suspend_scheduler(FAR struct tcb_s *tcb)
{
/* Handle the task exiting case */
- if (tcb != NULL)
+ if (tcb == NULL)
Review Comment:
`nxsched_resume_scheduler()` and `nxsched_suspend_scheduler()` are paired
functions. If the code resumes but skips suspend, the format in the trace will
be wrong, which is problematic for backend IDEs such as system view/perfetto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
