nuttxpr commented on PR #14218: URL: https://github.com/apache/nuttx/pull/14218#issuecomment-2409845629
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** meet the NuttX requirements, despite claiming "N/A" for impact. Here's why: * **Insufficient Summary:** Simply stating "Revert" without explaining the original problem these commits aimed to solve, why they are problematic, and the implications of reverting is insufficient. * **Missing Impact Details:** Reverting changes, especially those dealing with core components like pthread, scheduling, and atomic operations, will undoubtedly have an impact. Claiming "N/A" is misleading and unacceptable. The PR needs to clearly outline potential negative impacts like re-introducing bugs, breaking compatibility, or affecting performance. * **Vague Testing:** "ci-check" isn't descriptive enough. The PR needs to specify the target architectures, boards, and configurations tested, along with relevant logs demonstrating the reverts don't negatively impact functionality. **In short, this PR needs significant work to meet NuttX standards. The author needs to:** 1. **Expand the Summary:** Provide context for the reverts, explaining the original issue and the rationale for reverting. 2. **Thoroughly Detail Impact:** Analyze and document all potential impacts of these reverts, especially negative ones. 3. **Improve Testing Description:** Provide specific details about the testing environment and include comprehensive logs showcasing the before/after behavior. Without these improvements, the PR is incomplete and risks introducing regressions into the NuttX codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
