cederom commented on code in PR #2718:
URL: https://github.com/apache/nuttx-apps/pull/2718#discussion_r1800079024
##########
benchmarks/dhrystone/CMakeLists.txt:
##########
@@ -44,7 +44,10 @@ if(CONFIG_BENCHMARK_DHRYSTONE)
endif()
endif()
- set(CFLAGS -DMSC_CLOCK)
+ set(CFLAGS
Review Comment:
Not really, we already patch the release code `malloc` and boolean
statements, so we modify the code anyway, we can also patch the uninitialized
variables. Instead we want to disable build warnings that may hide potential
problems in future.
This kind of patching is common also in FreeBSD Ports. Then patches are
supposed to land in the upstream so they are not needed in future releases :-)
I can see some flags were present before, so okay, we may include them :-) I
would go for patching the upstream too :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
