JianyuWang0623 commented on code in PR #2737: URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1801533764
########## nshlib/nsh_parse.c: ########## @@ -2592,16 +2619,27 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline) FAR char *argv[MAX_ARGV_ENTRIES]; FAR char *saveptr; FAR char *cmd; - FAR char *redirfile_out = NULL; - FAR char *redirfile_in = NULL; - int oflags = 0; + struct nsh_exec_param_s param_exec = { + .fd_in = -1, + .fd_out = -1, + .oflags_in = 0, + .oflags_out = 0, + .file_in = NULL, + .file_out = NULL + }; + + int pipefd[2] = { Review Comment: > remove extra space Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org