xiaoxiang781216 commented on code in PR #2741:
URL: https://github.com/apache/nuttx-apps/pull/2741#discussion_r1803047927


##########
nshlib/nsh_fscmds.c:
##########
@@ -803,9 +803,21 @@ int cmd_cat(FAR struct nsh_vtbl_s *vtbl, int argc, FAR 
char **argv)
         {
           ssize_t n = nsh_read(vtbl, buf, BUFSIZ);
 
+          /* EOF */
+
           if (n == 0)

Review Comment:
   should we change to:
   ```
     if (n <= 0)
       {
         break;
      }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to