xiaoxiang781216 commented on code in PR #14130:
URL: https://github.com/apache/nuttx/pull/14130#discussion_r1804952006
##########
arch/arm64/src/Toolchain.defs:
##########
@@ -180,8 +180,14 @@ ifeq ($(CONFIG_LTO_FULL),y)
endif
endif
+ifeq ($(GCCVER),)
Review Comment:
why some guard by CONFIG_ARCH_TOOLCHAIN_GNU, but some not?
##########
arch/xtensa/src/lx6/Toolchain.defs:
##########
@@ -111,6 +111,10 @@ ifneq ($(CONFIG_LIBCXXTOOLCHAIN),y)
ARCHCXXFLAGS += -nostdinc++
endif
+ifeq ($(CONFIG_ARCH_TOOLCHAIN_GNU), y)
Review Comment:
```suggestion
ifeq ($(CONFIG_ARCH_TOOLCHAIN_GNU),y)
```
##########
arch/xtensa/src/lx7/Toolchain.defs:
##########
@@ -115,6 +115,10 @@ ifneq ($(CONFIG_LIBCXXTOOLCHAIN),y)
ARCHCXXFLAGS += -nostdinc++
endif
+ifeq ($(CONFIG_ARCH_TOOLCHAIN_GNU), y)
Review Comment:
```suggestion
ifeq ($(CONFIG_ARCH_TOOLCHAIN_GNU),y)
```
##########
arch/risc-v/src/cmake/Toolchain.cmake:
##########
@@ -259,7 +259,16 @@ if(CONFIG_RISCV_TOOLCHAIN STREQUAL GNU_RVG)
endif()
if(CONFIG_ARCH_RV_ISA_ZICSR_ZIFENCEI)
- set(ARCHCPUEXTFLAGS ${ARCHCPUEXTFLAGS}_zicsr_zifencei)
+ if(NOT DEFINED GCCVER)
Review Comment:
should move outside CONFIG_ARCH_RV_ISA_ZICSR_ZIFENCEI
##########
arch/risc-v/src/common/Toolchain.defs:
##########
@@ -210,7 +210,15 @@ ifeq ($(CONFIG_RISCV_TOOLCHAIN),GNU_RVG)
endif
ifeq ($(CONFIG_ARCH_RV_ISA_ZICSR_ZIFENCEI),y)
- ARCHCPUEXTFLAGS := $(ARCHCPUEXTFLAGS)_zicsr_zifencei
+ ifeq ($(GCCVER),)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
