nuttxpr commented on PR #14404: URL: https://github.com/apache/nuttx/pull/14404#issuecomment-2422338663
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX Requirements.** Here's why and what's missing: **Summary:** * **Missing:** * **Why is this change necessary?** What problem does colored output solve? Is it for readability, debugging, CI integration? Be specific about the benefits. * **What functional part of the code is being changed?** Is it a core NuttX logging mechanism, a specific driver, or a build system change? * **How does the change exactly work?** What code is modified to achieve colored output? Are you using ANSI escape codes, a library, or something else? **Impact:** * **You claim no impact on the build process, but does colored output work on all supported terminals and environments?** * **Documentation:** Even if the change seems small, you'll likely need to update the documentation to inform users about this new feature and how to enable/disable it (if applicable). * **Compatibility:** Will this change break anything for users who rely on parsing the existing log output format? **Testing:** * **Insufficient:** "Tested on the GNU compiler" is not nearly enough information. * **Provide specific operating system, compiler version, and target details.** * **Include relevant snippets of the "before" and "after" logs** that clearly demonstrate the colored output. **To make your PR acceptable:** 1. **Expand the Summary section significantly** with the missing details outlined above. 2. **Thoroughly consider the Impact section**, addressing documentation, compatibility, and any potential issues with different terminal types. 3. **Provide detailed testing information** including the specific environment and relevant log snippets. Remember, a good PR is not just about the code changes, but also about clearly communicating the *why*, *how*, and the potential impact of your changes to both users and the project maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
