nuttxpr commented on PR #14450: URL: https://github.com/apache/nuttx/pull/14450#issuecomment-2429173730
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is missing some key information: * **What functional part of the code is being changed?** While it mentions `up_ndelay` and `up_udelay`, it doesn't clearly state which files or modules are affected. * **How does the change exactly work?** It explains the problem but doesn't explicitly state how the PR fixes the issue. Does it use a different timer? Does it modify the existing logic? * **Related NuttX Issue reference if applicable.** This is crucial to track the bug being fixed. The **Impact** section is also lacking: * **Is new feature added? Is existing feature changed?** This is a bug fix, so it's changing an existing feature. * It only mentions fixing `up_udelay` issues. What are the broader implications? Does this fix affect other functionalities? * **Impact on build, hardware, documentation, security, compatibility?** These are all marked as NO without explanation. Even if there's no impact, it should be explicitly stated. The **Testing** section is insufficient: * **Build Host(s) information is missing.** * **Target information is vague.** "imx93 platform" is not specific enough. Which board and configuration are used? * **No testing logs provided.** Without concrete logs, it's impossible to verify the fix. **Overall:** This PR, as described, does **not** meet the NuttX requirements. It needs more detail and clarity in all sections, particularly regarding the solution's implementation, testing methodology, and potential impact beyond the immediate bug fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
