W-M-R commented on code in PR #14472: URL: https://github.com/apache/nuttx/pull/14472#discussion_r1811952549
########## Kconfig: ########## @@ -2774,6 +2774,7 @@ source "libs/libc/Kconfig" source "libs/libm/Kconfig" source "libs/libxx/Kconfig" source "libs/libdsp/Kconfig" +source "libs/libbuiltin/Kconfig" Review Comment: The library in compiler-rt is independent. For example, if certain functions are enabled, the functions inserted by the compiler into the program need to call the implementation in this library. In the LLVM-embedded-toolchain-for-Arm project, only libclang_rt.builtins_xxx.a is supported. If other functions are needed, such as we want to enable clang's gcov, the profile in compiler-rt needs to provide function implementations, but the arm llvm project does not support the rt.profile library, so we need to pull the library into nuttx and compile it like libcxx, similar to the patch https://github.com/apache/nuttx/pull/14327. It is not necessary to compile the compiler on nuttx.What brother xiang means is that since the profile library is ported, buitlin should be integrated into the nuttx compilation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
