nuttxpr commented on PR #14478: URL: https://github.com/apache/nuttx/pull/14478#issuecomment-2431318407
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR description is mostly okay, but could be improved for clarity and completeness against the NuttX requirements. Here's a breakdown: **Strengths:** * **Summary:** Clearly states the "why" (bug fix, syncing with TII branch) and "what" (9-16 bit transfer fix, cache invalidation optimization). * **Impact:** Correctly identifies the limited scope of impact (imx9, lpspi, >8-bit transfers). **Areas for Improvement:** * **Summary:** * **Functional part:** Be more specific than just "driver." Which file(s) were modified? * **How:** Briefly elaborate on HOW the buffer length handling was wrong and how it's now fixed. * **Issues/PRs:** Are there any related issues this PR addresses? If so, link them. * **Impact:** * **User impact:** While the impact is limited, will users see any functional changes (e.g., improved performance)? * **Build impact:** Unlikely, but state "NO" explicitly for completeness. * **Hardware:** Specify which imx9 board(s) were used for testing. * **Documentation:** Does the driver documentation need updating to reflect the fix? * **Security:** Unlikely, but state "NO" explicitly. * **Compatibility:** Unlikely, but state "NO" explicitly. * **Testing:** * **Build Host:** Provide details about your development environment. * **Targets:** Be specific about the "custom imx93 board" – is there a name or reference design? * **Logs:** While you mention "tested," concrete logs demonstrating the issue before and the fix after are crucial. **Concise Feedback:** The PR description is on the right track but lacks specifics in the "Impact" and "Testing" sections. Enhance it with detailed information about your build environment, target hardware, and, most importantly, provide comparative logs showcasing the fix in action. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
