nuttxpr commented on PR #14476: URL: https://github.com/apache/nuttx/pull/14476#issuecomment-2432082019
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This pull request appears to meet the basic NuttX requirements. However, it could be improved with some clarifications: **Summary:** * **More Detail:** Briefly explain why the busy wait address is needed. What was the specific issue causing the FVP SMP boot failure? * **Functional Change:** Be specific about which part of the code is modified. For example, "Added a busy wait loop in the ARM64 FVP platform initialization code". * **How it Works:** Explain at a high level how providing the busy wait address resolves the boot issue. **Impact:** * **Hardware:** While you mention "arm64 fvp smp", be explicit about the specific architectures and boards affected. * **Documentation:** If this fix impacts user understanding (e.g., if the busy wait address is configurable), mention if a documentation update is needed or provided. **Testing:** * **Build Host:** Specify the operating system, CPU architecture, and compiler used for testing. * **Target(s):** Provide the full architecture and board configuration used (e.g., "arm64, FVP:nsh_smp"). * **Logs:** While "ostest" is mentioned, consider including relevant snippets of the logs that demonstrate the issue before the fix and the successful outcome after the fix. By adding these details, you'll make it easier for reviewers to understand and evaluate your pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
