nuttxpr commented on PR #2789: URL: https://github.com/apache/nuttx-apps/pull/2789#issuecomment-2440324279
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not fully meet the NuttX Requirements.** Here's why: * **Summary:** While it mentions the change (adding `tinymembench`), it lacks details. * *Why* is this change necessary? What problem does it solve or feature does it add? * *How* does `tinymembench` work? What does it measure and how? * **Impact:** Even if the impact is minimal, you should explicitly state it. For example: * **Impact on user:** "Users can now use the `tinymembench` tool to benchmark memory performance." * **Impact on documentation:** "Documentation for `tinymembench` has been added." * **Testing:** * **Insufficient Detail:** "Tested on QEMU/x86" is too vague. Specify the QEMU version, the exact x86 target (e.g., qemuarm, qemux86-64), and the NuttX configuration used. * **Missing Logs:** You need to provide actual testing logs *before* and *after* the change. This demonstrates the tool's functionality and proves the patch works as intended. **To improve this PR:** 1. **Expand the Summary:** Explain the rationale and functionality of `tinymembench`. 2. **Clarify Impact:** Even if minimal, state the impact on users, documentation, etc. 3. **Provide Detailed Testing Information:** Include QEMU versions, target configurations, and actual testing logs demonstrating the tool's usage and results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
