nuttxpr commented on PR #14597: URL: https://github.com/apache/nuttx/pull/14597#issuecomment-2451728844
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the problem and the solution, it lacks crucial details required by the template. Here's a breakdown of missing information: * **Summary:** Missing a clear statement of *what* functional part of the code is being changed (e.g., `fs/readv.c`, libc implementation, etc.). The explanation of *how* the change works is also vague. "This fix is enough for read/write, where iovcnt is always 1" doesn't explain the actual code changes. Crucially, the related NuttX issue number is missing. * **Impact:** The impact section is severely incomplete. It needs to address *all* the points in the template with specific YES/NO answers and descriptions where applicable. Simply stating "read/write on character devices or such" doesn't adequately cover the potential impact. Consider impacts on backward compatibility, documentation needs, and whether this is a new feature, a bug fix, or a performance improvement. * **Testing:** The testing information is insufficient. While a target is mentioned (esp32-devkitc), the build host details are absent. More importantly, there are no "Testing logs before change" and "Testing logs after change" as requested by the template. Even a simple demonstration of the fix working would be beneficial. Mentioning another PR adds complexity and makes it harder to assess the impact of *this* specific change in isolation. **To make this PR compliant, the author needs to:** 1. **Clarify the Summary:** Specify the affected files and provide a more technical explanation of the code changes. Include the related NuttX issue number. 2. **Complete the Impact Assessment:** Answer all the questions in the Impact section with YES/NO and provide details where necessary. 3. **Provide Adequate Testing Information:** List the build host details (OS, CPU, compiler). Include "before" and "after" logs demonstrating the fix, even if they are simple. Ideally, the test should be self-contained and not rely on other PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
