nuttxpr commented on PR #14751: URL: https://github.com/apache/nuttx/pull/14751#issuecomment-2472168572
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and links to related issues, it is missing crucial information. Here's what's missing: * **Summary:** Lacks details on *what* functional part of the code the original commit changed and *how* this revert addresses the regressions. Simply stating "regressions are reported" is insufficient. It needs to explain the nature of the regressions. * **Impact:** Completely empty. Needs to be filled out for all sections. At a minimum, it should indicate if this revert affects users, the build process, hardware, documentation, security, or compatibility. Since it reverts a previous change, it likely impacts some of these. * **Testing:** Empty. Needs to include information on the build host and targets used for testing, as well as the actual test logs before and after the revert. The logs should demonstrate that the regressions are indeed fixed. Without this information, it's difficult to assess the impact of the revert and ensure it doesn't introduce new issues. The PR author needs to provide these missing details before it can be properly reviewed and merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
