yamt commented on code in PR #14761: URL: https://github.com/apache/nuttx/pull/14761#discussion_r1839998297
########## sched/irq/irq_csection.c: ########## @@ -75,6 +75,18 @@ volatile uint8_t g_cpu_nestcount[CONFIG_SMP_NCPUS]; * Private Functions ****************************************************************************/ +static bool csection_degraded(void) Review Comment: i added the check to enter_critical_section because i felt it logically belonged there, not the caller. > https://github.com/apache/nuttx/pull/12281 this patch remove the judgement i was not aware of the history. if we decided that enter_critical_section should not be used early in the boot, it's better to have a DIAGASSERT there to assert it. how do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
