nuttxpr commented on PR #14812: URL: https://github.com/apache/nuttx/pull/14812#issuecomment-2478722217
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. The summary is insufficiently detailed. It mentions a problem and a solution, but doesn't explain *why* the other changes to `tcb->flag` are problematic or what the actual implemented change is. It needs to be more descriptive and answer all the questions posed in the template. The Impact section is far too brief and doesn't address *any* of the specific questions. The Testing section provides no useful information. It needs to specify the host and target details along with *actual* log output, not just a reference to "ci ostest." Here's a breakdown of what's missing: **Summary:** * **Missing:** What specific "unrelated changes" were happening? Why are they a problem (e.g., race conditions, incorrect state, etc.)? *How* does the change prevent these issues? Be explicit. **Impact:** * **Missing all details:** Needs to answer all the "Impact on..." questions with specific yes/no answers and descriptions where applicable. Even if the answer is "no," explicitly state it. For example: "Impact on user: NO." **Testing:** * **Missing vital information:** "ci ostest" is not sufficient. Provide details about the build host (OS, CPU architecture, compiler version). Provide details about the target (architecture, board, configuration). Most importantly, provide *actual log output* demonstrating the issue before the change and the corrected behavior after the change. Don't just say logs exist; show them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
