nuttxpr commented on PR #14819: URL: https://github.com/apache/nuttx/pull/14819#issuecomment-2480607786
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not meet the NuttX requirements. The provided information is far too vague and lacks crucial details. Here's why: * **Summary:** "since it's not necessary to limit the number of map entries" is not a sufficient explanation. What map entries? What was the limit? Why was it there in the first place? What part of the codebase was changed? What is the *functional* change? This section needs to clearly articulate the *what* and *why* of the change. Issue references are missing. * **Impact:** "remove the artificial limitation" is similarly vague. *What* limitation? What are the ramifications of removing it? While it *says* it impacts the user, build, etc., by saying "NO", it provides no reasoning or context. For a proper assessment, consider the memory usage implications of removing this limit. Could it lead to out-of-memory errors in certain scenarios? Even if the answer to all impacts *is* "NO", a brief justification ("No change to user experience," for example) is preferable for clarity. * **Testing:** "ci" is insufficient. "ci" presumably means Continuous Integration, but that doesn't provide any specifics. What targets were tested? What tests were run? What were the *results*? Crucially, there are no "before" and "after" logs demonstrating the actual change in behavior. This section requires concrete evidence that the change works as intended and doesn't introduce regressions. In short, the PR description needs significantly more detail and concrete information to be considered acceptable. It needs to provide a clear understanding of the change, its implications, and thorough verification through testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
