nuttxpr commented on PR #14822: URL: https://github.com/apache/nuttx/pull/14822#issuecomment-2480630581
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements as described. While it provides a summary of the changes, it lacks crucial details and context. Here's a breakdown of the missing information: * **Summary:** While it lists the changes made, it doesn't explain *why* these changes are necessary. What problem are they solving? What's the motivation behind reverting to polling mode, removing product configs, etc.? How exactly do these changes work? What is the mechanism by which the code reverts to polling? This section needs significant expansion. Issue/PR references are also missing. * **Impact:** Simply stating "Kconfig" is insufficient. It needs to explicitly answer the questions about user impact, build impact, hardware impact, documentation impact, security impact, and compatibility impact. For example, if the Kconfig is changed, does this mean the user needs to reconfigure their build? Are any boards no longer supported? Does removing product-specific configs simplify the build process? Be explicit with "YES" or "NO" for each impact item and then provide a description if the answer is "YES." * **Testing:** "ci" is not adequate testing information. The PR needs to specify the build host OS, CPU architecture, and compiler used. It also needs to specify the target architecture and board configuration used for testing. Critically, it's missing the "before" and "after" testing logs that demonstrate the change's effectiveness. Just saying "ci" doesn't provide any verifiable evidence of the changes working as intended. The CI results themselves should be linked in the PR, not just mentioned. In short, the PR needs to be significantly more detailed and explicit in all sections to meet the NuttX requirements. It needs to provide the "why," "how," and verifiable "proof" for each change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
