nuttxpr commented on PR #2859: URL: https://github.com/apache/nuttx-apps/pull/2859#issuecomment-2483255044
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements as described. While it provides a link to a more detailed description, the PR summary itself lacks crucial information. It doesn't explain *why* this change is necessary, *how* it works, or what functional part of the code is changed *within the PR description itself*. Relying solely on an external link is discouraged. The Impact section is entirely empty. This is a significant omission. At a minimum, it needs to address all the listed points, even if the answer is "NO" for most. The Testing section is also insufficient. It simply states "qemu." It needs to specify the *host* operating system, compiler details, the specific qemu *target* architecture/board/configuration, and, crucially, the *actual testing logs* before and after the change. Simply stating "qemu" offers no evidence of testing efficacy. Therefore, to meet the requirements, the PR needs to: 1. **Expand the Summary:** Explain the rationale for supporting gcov output to stdout, describe the code changes made to achieve this (e.g., which files were modified and how), and explicitly state the functional area affected (e.g., system/build system/debugging tools). While linking to the full PR is helpful, the core information should be present within the description itself. 2. **Complete the Impact section:** Address each point, even if the answer is "NO." Justify each answer. For example, if there's no user impact, explain why. 3. **Provide detailed testing information:** Specify the build host OS, CPU, compiler (including version), the target architecture, board, and configuration used with qemu. Most importantly, include the actual *before* and *after* testing logs demonstrating the change's effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
