nuttxpr commented on PR #14864: URL: https://github.com/apache/nuttx/pull/14864#issuecomment-2487642614
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** fully meet the NuttX requirements yet, although it's on the right track. Here's why: * **Missing crucial details in the Summary:** The provided summary is a title, not a description. It *states* what the change does technically, but doesn't explain *why* it's necessary. What problem did the old approach cause? What are the benefits of using a refcount and an explicit uninitialize interface? These are essential for reviewers to understand the context and value of the change. * **Incomplete Impact Assessment:** The Impact section is entirely placeholder text. Every bullet point needs to be addressed specifically. Even if the answer is "NO", it should explicitly state "NO" followed by a brief justification (e.g., "Impact on user: NO - This is an internal change to driver initialization and does not affect user-facing APIs."). If there *is* an impact, it needs a detailed explanation. * **Missing Testing Information:** The Testing section is also placeholder text. You must provide details about your testing environment (host OS, compiler, target architecture, board, configuration) and, crucially, the logs demonstrating the behavior before and after the change. These logs are the primary evidence that your change works as intended and doesn't introduce regressions. **To make this PR compliant, you need to:** 1. **Expand the Summary:** Explain the rationale for the change, the problems it solves, and the benefits it provides. 2. **Complete the Impact Assessment:** Address every bullet point in the Impact section, providing specific answers and justifications. 3. **Provide Testing Details and Logs:** Describe your testing environment and include the "before" and "after" logs demonstrating the change's effect. By filling in these missing pieces, you'll provide reviewers with the information they need to understand, evaluate, and ultimately merge your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
