xiaoxiang781216 commented on code in PR #14927:
URL: https://github.com/apache/nuttx/pull/14927#discussion_r1856490950
##########
drivers/note/notelog_driver.c:
##########
@@ -61,7 +61,7 @@ static void notelog_cpu_resumed(FAR struct note_driver_s *drv,
# endif
#endif
#ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION
-static void notelog_premption(FAR struct note_driver_s *drv,
+static void notelog_preemption(FAR struct note_driver_s *drv,
FAR struct tcb_s *tcb, bool locked);
Review Comment:
```suggestion
FAR struct tcb_s *tcb, bool locked);
```
##########
drivers/note/notelog_driver.c:
##########
@@ -103,7 +103,7 @@ static const struct note_driver_ops_s g_notelog_ops =
# endif
#endif
#ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION
- notelog_premption, /* premption */
+ notelog_preemption, /* preemption */
Review Comment:
```suggestion
notelog_preemption, /* preemption */
```
##########
include/nuttx/sched.h:
##########
@@ -702,10 +702,10 @@ struct tcb_s
#endif
#if CONFIG_SCHED_CRITMONITOR_MAXTIME_PREEMPTION >= 0
- clock_t premp_start; /* Time when preemption disabled */
- clock_t premp_max; /* Max time preemption disabled */
- void *premp_caller; /* Caller of preemption disabled */
- void *premp_max_caller; /* Caller of max preemption */
+ clock_t preemp_start; /* Time when preemption disabled */
Review Comment:
```suggestion
clock_t preemp_start; /* Time when preemption disabled
*/
```
##########
drivers/note/notesnap_driver.c:
##########
@@ -86,7 +86,7 @@ static void notesnap_cpu_resumed(FAR struct note_driver_s
*drv,
# endif
#endif
#ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION
-static void notesnap_premption(FAR struct note_driver_s *drv,
+static void notesnap_preemption(FAR struct note_driver_s *drv,
FAR struct tcb_s *tcb, bool locked);
Review Comment:
```suggestion
FAR struct tcb_s *tcb, bool locked);
```
##########
drivers/note/notelog_driver.c:
##########
@@ -255,7 +255,7 @@ static void notelog_cpu_resumed(FAR struct note_driver_s
*drv,
#endif
#ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION
-static void notelog_premption(FAR struct note_driver_s *drv,
+static void notelog_preemption(FAR struct note_driver_s *drv,
FAR struct tcb_s *tcb, bool locked)
Review Comment:
```suggestion
FAR struct tcb_s *tcb, bool locked)
```
##########
drivers/note/notesnap_driver.c:
##########
@@ -302,7 +302,7 @@ static void notesnap_cpu_resumed(FAR struct note_driver_s
*drv,
#endif
#ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION
-static void notesnap_premption(FAR struct note_driver_s *drv,
+static void notesnap_preemption(FAR struct note_driver_s *drv,
FAR struct tcb_s *tcb, bool locked)
Review Comment:
```suggestion
FAR struct tcb_s *tcb, bool locked)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
