nuttxpr commented on PR #14965: URL: https://github.com/apache/nuttx/pull/14965#issuecomment-2503651275
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details. Here's why: * **Insufficient Summary:** "Remove TABs" is too vague. Which files were affected? Why were tabs removed (coding style compliance)? What part of the codebase was changed? * **Impact Too Brief:** Even if the impact is minimal, it needs to explicitly address *all* the points. State "NO" for each if truly no impact. For example: * Impact on user: NO * Impact on build: NO * ...and so on for all impact categories. * **Testing Inadequate:** "local nxstyle" doesn't provide enough information. What platform was nxstyle run on? What were the *results* of running nxstyle before and *after* the change? Ideally, show the nxstyle output demonstrating the tabs were present before and absent after. If other testing was performed (building and running on a target), that should be documented as well. Empty code blocks for "Testing logs before change" and "Testing logs after change" are not helpful. To meet the requirements, the PR needs to be much more detailed and explicit, even for seemingly simple changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
