nuttxpr commented on PR #15050: URL: https://github.com/apache/nuttx/pull/15050#issuecomment-2517892027
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides *some* information, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** The summary is too vague. It states "since these arch doesn't distinguish between near and far pointers," but doesn't explain *why* the change is necessary. What problem does this solve? What code is being refactored and why? What is the intended outcome of the refactoring? * **Impact:** While it claims a "minor code refactor," it doesn't address *any* of the specific impact questions. Even if the changes are minor, the PR author needs to explicitly state "NO" or provide a brief explanation for each impact category (user, build, hardware, documentation, security, compatibility). * **Testing:** "ci" is insufficient. While Continuous Integration testing is important, the PR needs to demonstrate *specific* local testing results. This includes: * Listing the specific build host and target environments used for testing. "ci" doesn't tell us which architectures or boards were tested. * Providing *actual* test logs (even if they are short) before and after the change to demonstrate the impact of the change. Simply stating "ci" doesn't offer any evidence of successful testing. The PR author needs to significantly expand on these sections to meet the NuttX requirements. Without more details, reviewers cannot effectively evaluate the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
