nuttxpr commented on PR #2878: URL: https://github.com/apache/nuttx-apps/pull/2878#issuecomment-2518867924
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements. The summary clearly explains the reason for the change (workaround for MbedTLS issue), the affected code (MbedTLS), and how it works (defining a macro). The impact section details the effects on the build process and explains the lack of other impacts. The testing section provides evidence of successful testing, including the host and target environment and logs (although "before" logs are not strictly necessary given the nature of the fix). It would strengthen the PR to add a reference to the upstream issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
